Skip to content
This repository was archived by the owner on Apr 11, 2025. It is now read-only.

Conversation

@cbrunsdon
Copy link

The dev dependencies were too restrictive to use this with 1.3.

This also gets the tests running.

Clarke Brunsdon and others added 12 commits May 23, 2016 15:38
2.x is pretty ancient and won't run on > ruby 2.2
Not all example groups should have the controller methods applied.
Stripped in solidus
Of course this flexible won't work everywhere, but calling bankruptcy on
guessing which versions are minimum for right now
Since this branch is to support Solidus, we probably want to be sending
along the Solidus version and not the Spree version. Spree.version is
removed as of Solidus 2.x and will actually cause errors.
In the JavaScript, it's better for us to rely on the name of the input to determine if the customer has chosen Affirm. Picking the first checked radio button will cause some issues with [the wallet code](https://github.com/solidusio/solidus/blob/master/frontend/app/views/spree/checkout/_payment.html.erb#L6) as well as anywhere that chooses a different method of recording the payment method ID.
Make payment method check more resilient
This commit into core:
solidusio/solidus@547d459

Added a check if payment sources are `#reusable?`. The
`SolidusAffirm::Checkout` model here is used as the payment source, but
doesn't implement that method, causing any code that looks up reusable
sources to throw a method missing error.

One example where I've seen this error is the /admin/payments/new page.
Make Affirm checkouts non-reusable
Some strings we print on _affirm.html.erb may contain quotes and must be escaped.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants